Skip to content

Commit

Permalink
Refine CI process (#2948)
Browse files Browse the repository at this point in the history
1. Drop unnecessary artifact uploading
2. Drop unnecessary tests to avoid timeout
  • Loading branch information
siyuan0322 committed Jun 28, 2023
1 parent 555b13d commit 92da638
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 41 deletions.
21 changes: 2 additions & 19 deletions .github/workflows/gss.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,23 +149,6 @@ jobs:
docker build -t ${{ env.GSS_IMAGE }}:${SHORT_SHA} \
-f .github/workflows/docker/graphscope-store.Dockerfile .
- name: Prepare the log directory
run: |
# create the helm installation log directory
mkdir -p ${{ github.workspace }}/k8s-ci-helm-installation-logs
# create the demo fresh of helm installation log directory
mkdir -p ${{ github.workspace }}/k8s-ci-demo-fresh-of-helm-installation-logs
# create the demo script of helm installation with pv log directory
mkdir -p ${{ github.workspace }}/k8s-ci-demo-script-of-helm-installation-with-pv-logs
# create the helm test of helm installation with pv log directory
mkdir -p ${{ github.workspace }}/k8s-ci-helm-test-of-helm-installation-with-pv-logs
# create the demo after restart of helm installation with pv log directory
mkdir -p ${{ github.workspace }}/k8s-ci-demo-after-restart-of-helm-installation-with-pv-logs
- name: Setup SSH
run: |
ssh-keygen -t rsa -f ~/.ssh/id_rsa -N ''
Expand Down Expand Up @@ -263,10 +246,10 @@ jobs:
MODE: stop

- name: upload the k8s logs to artifact
if: ${{ always() }}
if: ${{ failure() }}
uses: actions/upload-artifact@v3
continue-on-error: true
with:
name: k8s-test-logs
path: ${{ github.workspace }}/k8s-ci-*-logs
path: ${{ github.workspace }}/helm-installation-logs

2 changes: 1 addition & 1 deletion charts/graphscope-store/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ image:
registry: registry.cn-hongkong.aliyuncs.com
repository: graphscope/graphscope-store
# Overrides the image tag whose default is the chart appVersion.
tag: "0.22.0"
tag: "0.23.0"
digest: ""
## Specify a imagePullPolicy
## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
Expand Down
21 changes: 0 additions & 21 deletions python/graphscope/tests/kubernetes/test_demo_script.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,30 +811,9 @@ def test_helm_installation(data_dir, modern_graph_data_dir):
simple_g = sub_graph.project(vertices={"person": []}, edges={"knows": []})

pr_result = graphscope.pagerank(simple_g, delta=0.8)
tc_result = graphscope.triangles(simple_g)

# add the PageRank and triangle-counting results as new columns to the property graph
sub_graph.add_column(pr_result, {"Ranking": "r"})
sub_graph.add_column(tc_result, {"TC": "r"})

# test subgraph on modern graph
mgraph = load_modern_graph(sess, modern_graph_data_dir)

# Interactive engine
minteractive = sess.gremlin(mgraph)
msub_graph = minteractive.subgraph( # noqa: F841
'g.V().hasLabel("person").outE("knows")'
)
person_count = (
minteractive.execute(
'g.V().hasLabel("person").outE("knows").bothV().dedup().count()'
)
.all()
.result()[0]
)
msub_interactive = sess.gremlin(msub_graph)
sub_person_count = msub_interactive.execute("g.V().count()").all().result()[0]
assert person_count == sub_person_count


def test_modualize():
Expand Down

0 comments on commit 92da638

Please sign in to comment.