Skip to content

Commit

Permalink
Deploy the vineyard rpc service as the session.service
Browse files Browse the repository at this point in the history
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
  • Loading branch information
dashanji committed May 30, 2023
1 parent a4909e7 commit de68992
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion coordinator/gscoordinator/cluster_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def vineyard_service_name(self):
def get_vineyard_service_endpoint(self, api_client):
# return f"{self.vineyard_service_name}:{self._vineyard_service_port}"
service_name = self.vineyard_service_name
service_type = "ClusterIP"
service_type = self._service_type
if self.vineyard_deployment_exists():
service_name = self._vineyard_deployment + "-rpc"
endpoints = get_service_endpoints(
Expand Down
1 change: 1 addition & 0 deletions coordinator/gscoordinator/kubernetes_launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,7 @@ def _inject_vineyard_as_sidecar(self, workload):
sidecar_size=self._vineyard_shared_mem,
sidecar_cpu=self._vineyard_cpu,
sidecar_memory=self._vineyard_mem,
sidecar_service_type=self._service_type,
output="json",
capture=True,
)
Expand Down

0 comments on commit de68992

Please sign in to comment.