Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not compatible with Python<3.9 #1305

Closed
sighingnow opened this issue Jan 28, 2022 · 0 comments · Fixed by #1304
Closed

[BUG] Not compatible with Python<3.9 #1305

sighingnow opened this issue Jan 28, 2022 · 0 comments · Fixed by #1304
Assignees
Labels
bug Something isn't working component:python

Comments

@sighingnow
Copy link
Collaborator

Describe the bug

cancel_futures was added since Python 3.9.

Error: -27 16:48:33,599 [ERROR][rpc:222]: Runstep failed with code: INTERACTIVE_ENGINE_INTERNAL_ERROR, message: Error occurred during preprocessing, The traceback is: Traceback (most recent call last):
  File "/Users/runner/.local/lib/python3.8/site-packages/gscoordinator/coordinator.py", line 696, in _create_interactive_instance
    if check_gremlin_server_ready(maxgraph_endpoint):
  File "/Users/runner/.local/lib/python3.8/site-packages/gscoordinator/utils.py", line 1779, in check_gremlin_server_ready
    executor.shutdown(wait=False, cancel_futures=True)
TypeError: shutdown() got an unexpected keyword argument 'cancel_futures'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/runner/.local/lib/python3.8/site-packages/gscoordinator/coordinator.py", line 516, in RunStep
    self.run_on_interactive_engine(
  File "/Users/runner/.local/lib/python3.8/site-packages/gscoordinator/coordinator.py", line 433, in run_on_interactive_engine
    op_result = self._create_interactive_instance(op)
  File "/Users/runner/.local/lib/python3.8/site-packages/gscoordinator/coordinator.py", line 722, in _create_interactive_instance
    raise RuntimeError("Create interactive instance failed.") from e
RuntimeError: Create interactive instance failed.

See also: https://github.com/alibaba/GraphScope/runs/4967615199?check_suite_focus=true, and https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Executor.shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants