-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GAIA-IR] Map KeyId back into KeyName for labels and properties #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid potential cyclice dependencies while using the library in pegasus.
…o tag_name in sink op
[IR Runtime] IR TagOpt for more compact structure in Runtime
BingqingLyu
requested review from
longbinlai and
shirly121
and removed request for
longbinlai and
shirly121
May 24, 2022 09:33
BingqingLyu
added this to In progress
in [Sprint 05.16-06.02] GraphScope New Interface Implementation & Benchmark Prepare
via automation
May 24, 2022
BingqingLyu
changed the title
[IR] Map KeyId back into KeyName for labels and properties
[GAIA-IR] Map KeyId back into KeyName for labels and properties
May 24, 2022
longbinlai
moved this from In progress
to Review in progress
in [Sprint 05.16-06.02] GraphScope New Interface Implementation & Benchmark Prepare
May 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1615 +/- ##
===========================================
- Coverage 73.15% 40.31% -32.85%
===========================================
Files 89 89
Lines 9727 9727
===========================================
- Hits 7116 3921 -3195
- Misses 2611 5806 +3195
Continue to review full report at Codecov.
|
[Sprint 05.16-06.02] GraphScope New Interface Implementation & Benchmark Prepare
automation
moved this from Review in progress
to Reviewer approved
May 26, 2022
lidongze0629
approved these changes
May 26, 2022
[Sprint 05.16-06.02] GraphScope New Interface Implementation & Benchmark Prepare
automation
moved this from Reviewer approved
to Done
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Map a label/property id back into label/property name in compiler, with id-name-mapping method provided in ir-core.
Related issue number
#1521