Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support valueMap() to fetch all properties of vertices #1623

Merged
merged 2 commits into from
May 27, 2022
Merged

support valueMap() to fetch all properties of vertices #1623

merged 2 commits into from
May 27, 2022

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented May 26, 2022

What do these changes do?

  1. support valueMap() in gremlin grammar
  2. translate valueMap() to expression '@.~all', and select('a').by(valueMap()) to '@A.~all'

Related issue number

Fixes #1622

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #1623 (bf95991) into main (b452508) will decrease coverage by 32.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1623       +/-   ##
===========================================
- Coverage   73.18%   40.27%   -32.91%     
===========================================
  Files          89       89               
  Lines        9736     9736               
===========================================
- Hits         7125     3921     -3204     
- Misses       2611     5815     +3204     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.41%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b452508...bf95991. Read the comment docs.

@lidongze0629 lidongze0629 merged commit 87b5613 into alibaba:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support valueMap operation in GAIA engine
3 participants