Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the install_deps.sh script #1873

Merged
merged 23 commits into from
Jul 29, 2022
Merged

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Jul 22, 2022

What do these changes do?

Related issue number

Fixes #1849

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #1873 (4495f25) into main (e5cdf48) will increase coverage by 29.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1873       +/-   ##
===========================================
+ Coverage   43.81%   72.99%   +29.17%     
===========================================
  Files          89       89               
  Lines        9804     9804               
===========================================
+ Hits         4296     7156     +2860     
+ Misses       5508     2648     -2860     
Impacted Files Coverage Δ
python/graphscope/deploy/kubernetes/utils.py 70.47% <0.00%> (+0.95%) ⬆️
python/graphscope/framework/dag.py 81.63% <0.00%> (+1.02%) ⬆️
python/graphscope/client/rpc.py 92.59% <0.00%> (+2.77%) ⬆️
python/graphscope/client/utils.py 85.09% <0.00%> (+3.72%) ⬆️
python/graphscope/framework/graph_schema.py 65.44% <0.00%> (+5.88%) ⬆️
python/graphscope/client/session.py 75.00% <0.00%> (+8.03%) ⬆️
python/graphscope/framework/utils.py 65.88% <0.00%> (+10.93%) ⬆️
python/graphscope/framework/operation.py 87.67% <0.00%> (+10.95%) ⬆️
python/graphscope/framework/app.py 92.01% <0.00%> (+11.73%) ⬆️
python/graphscope/framework/graph_utils.py 82.53% <0.00%> (+12.30%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5cdf48...4495f25. Read the comment docs.

@acezen acezen requested a review from yecol July 28, 2022 02:18
@acezen acezen marked this pull request as ready for review July 28, 2022 02:18
scripts/install_deps.sh Outdated Show resolved Hide resolved
@acezen acezen merged commit cd08a1a into alibaba:main Jul 29, 2022
@acezen acezen deleted the acezen/install_deps branch July 29, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the install_deps.sh, or make the documentc around it better.
3 participants