Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test filter push down #2003

Merged
merged 6 commits into from
Sep 22, 2022
Merged

test filter push down #2003

merged 6 commits into from
Sep 22, 2022

Conversation

waruto210
Copy link
Contributor

What do these changes do?

Test for the column filter push down in groot

Related issue number

#1530

@waruto210
Copy link
Contributor Author

get_vertex method of trait ReadGraph is used to read vertex, and now ir assume that it can get all props from the returned vertex locally, so enable column_filter_pushdown causes error.

@waruto210 waruto210 force-pushed the test_filter_pushdown branch 3 times, most recently from a2b7021 to a853882 Compare September 6, 2022 14:18
@waruto210 waruto210 changed the title enable column filter push down in groot for test test filter push down Sep 6, 2022
@waruto210 waruto210 force-pushed the test_filter_pushdown branch 2 times, most recently from 254810c to 491714a Compare September 9, 2022 08:22
@waruto210 waruto210 marked this pull request as ready for review September 9, 2022 08:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #2003 (74c88f5) into main (516b24a) will increase coverage by 4.99%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   35.21%   40.21%   +4.99%     
==========================================
  Files          89       89              
  Lines        9845     9845              
==========================================
+ Hits         3467     3959     +492     
+ Misses       6378     5886     -492
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/hosts/cluster.py 29.41% <0.00%> (-58.83%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-44.68%) ⬇️
python/graphscope/framework/graph_schema.py 55.28% <0.00%> (-6.98%) ⬇️
python/graphscope/framework/utils.py 40.10% <0.00%> (-4.95%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-3.20%) ⬇️
python/graphscope/framework/app.py 69.95% <0.00%> (-1.88%) ⬇️
python/graphscope/tests/conftest.py 49.13% <0.00%> (ø)
python/graphscope/client/rpc.py 81.48% <0.00%> (+3.70%) ⬆️
python/graphscope/client/utils.py 81.36% <0.00%> (+4.96%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 588ce29...74c88f5. Read the comment docs.

@waruto210 waruto210 force-pushed the test_filter_pushdown branch 3 times, most recently from 03fd6c7 to fcd7190 Compare September 9, 2022 12:55
BingqingLyu
BingqingLyu reviewed Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@waruto210 waruto210 force-pushed the test_filter_pushdown branch 2 times, most recently from e6fb6bf to 5033fed Compare September 21, 2022 01:53
BingqingLyu
BingqingLyu reviewed Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

BingqingLyu
BingqingLyu reviewed Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

BingqingLyu
BingqingLyu approved these changes Sep 22, 2022
View reviewed changes
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit 7741be0 into alibaba:main Sep 22, 2022
@waruto210 waruto210 mentioned this pull request Sep 27, 2022
Closed
@waruto210 waruto210 deleted the test_filter_pushdown branch September 28, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BingqingLyu BingqingLyu BingqingLyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waruto210 @codecov-commenter @BingqingLyu