Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New predicate support #2086

Merged
merged 15 commits into from Oct 8, 2022
Merged

Conversation

waruto210
Copy link
Contributor

What do these changes do?

add support of start/end_with for condition filter

Related issue number

#1530
#2074

@waruto210
Copy link
Contributor Author

please merge #2074 first, then i can rebase on main.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #2086 (09b47bd) into main (eb393da) will decrease coverage by 3.71%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2086      +/-   ##
==========================================
- Coverage   43.76%   40.05%   -3.72%     
==========================================
  Files          87       87              
  Lines        9891     9891              
==========================================
- Hits         4329     3962     -367     
- Misses       5562     5929     +367     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/hosts/cluster.py 29.41% <0.00%> (-58.83%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-44.68%) ⬇️
python/graphscope/framework/utils.py 40.10% <0.00%> (-14.85%) ⬇️
python/graphscope/framework/app.py 69.95% <0.00%> (-10.33%) ⬇️
python/graphscope/client/rpc.py 81.48% <0.00%> (-8.34%) ⬇️
python/graphscope/framework/graph_schema.py 52.73% <0.00%> (-6.63%) ⬇️
python/graphscope/tests/conftest.py 48.81% <0.00%> (-4.41%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-3.20%) ⬇️
python/graphscope/framework/graph_utils.py 67.46% <0.00%> (-2.78%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb393da...09b47bd. Read the comment docs.

@waruto210 waruto210 marked this pull request as ready for review October 1, 2022 16:14
uncomment debug_assert
Copy link
Collaborator

@BingqingLyu BingqingLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BingqingLyu BingqingLyu merged commit b6d68bc into alibaba:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants