Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE/Runtime] Refine some error infos in Runtime #2113

Merged
merged 4 commits into from Oct 12, 2022

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Oct 9, 2022

What do these changes do?

As titled.

Related issue number

Fixes #2115

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #2113 (2e4fa44) into main (5756de3) will decrease coverage by 3.78%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
- Coverage   43.83%   40.05%   -3.79%     
==========================================
  Files          87       87              
  Lines        9891     9891              
==========================================
- Hits         4336     3962     -374     
- Misses       5555     5929     +374     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/deploy/hosts/cluster.py 29.41% <0.00%> (-58.83%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-44.68%) ⬇️
python/graphscope/framework/utils.py 40.10% <0.00%> (-14.85%) ⬇️
python/graphscope/framework/app.py 69.95% <0.00%> (-10.33%) ⬇️
python/graphscope/client/rpc.py 81.48% <0.00%> (-8.34%) ⬇️
python/graphscope/framework/graph_schema.py 52.73% <0.00%> (-6.63%) ⬇️
python/graphscope/tests/conftest.py 48.81% <0.00%> (-4.41%) ⬇️
python/graphscope/analytical/udf/utils.py 36.17% <0.00%> (-3.20%) ⬇️
python/graphscope/client/session.py 63.24% <0.00%> (-2.97%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5756de3...2e4fa44. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all error message can be reorganized into some uniform format.

@longbinlai longbinlai merged commit 31829fd into alibaba:main Oct 12, 2022
@BingqingLyu BingqingLyu deleted the refine_error branch November 29, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine error infos in GIE/Runtime
3 participants