Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE pegasus] Support cancelling query. #2168

Merged
merged 9 commits into from
Nov 1, 2022
Merged

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Oct 26, 2022

What do these changes do?

  1. Query will be cancelled when timeout
  2. User can cancel running job by set cancel hook in ResultSink
  3. ResultSink will call method on_error when query is cancelled

Related issue number

Resolves #1867

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #2168 (957e4ab) into main (74af74f) will decrease coverage by 32.92%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2168       +/-   ##
===========================================
- Coverage   72.93%   40.01%   -32.93%     
===========================================
  Files          89       87        -2     
  Lines        9789     9752       -37     
===========================================
- Hits         7140     3902     -3238     
- Misses       2649     5850     +3201     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.19%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.00%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.72%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74af74f...957e4ab. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for now.

@siyuan0322 siyuan0322 merged commit f983bd6 into alibaba:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support nonblocking and cancelling query in pegasus.
5 participants