Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] make ResultCode in IrCore consistent with that in IrCompiler #2188

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Nov 1, 2022

What do these changes do?

As titled.

Related issue number

Fixes #2190

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Merging #2188 (3967411) into main (abdd5c9) will decrease coverage by 31.72%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2188       +/-   ##
===========================================
- Coverage   71.73%   40.01%   -31.73%     
===========================================
  Files          89       87        -2     
  Lines        9789     9752       -37     
===========================================
- Hits         7022     3902     -3120     
- Misses       2767     5850     +3083     
Impacted Files Coverage Δ
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.19%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.00%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.72%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
python/graphscope/analytical/udf/wrapper.py 27.27% <0.00%> (-72.73%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abdd5c9...3967411. Read the comment docs.

@longbinlai longbinlai merged commit 4279b8f into alibaba:main Nov 7, 2022
@BingqingLyu BingqingLyu deleted the code_error_fix branch November 29, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GIE-Compiler throw NullPointer exception when receiving Others error from IrCore
3 participants