Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor improvement in logs and configurations of groot. #2371

Merged
merged 4 commits into from Jan 4, 2023

Conversation

siyuan0322
Copy link
Collaborator

What do these changes do?

  1. Rename groot config file from my.cnf to groot.config for better readability
  2. Fix a bug that rust log are not redirect to console
  3. Enable reload of logback for java servers
  4. Bump up version of rust log crate
  5. Fix the log output location.

Related issue number

Fixes

@codecov-commenter
Copy link

Codecov Report

Merging #2371 (de05d7e) into main (a0662ac) will decrease coverage by 32.30%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2371       +/-   ##
===========================================
- Coverage   72.30%   40.00%   -32.31%     
===========================================
  Files          88       88               
  Lines        9711     9711               
===========================================
- Hits         7022     3885     -3137     
- Misses       2689     5826     +3137     
Impacted Files Coverage Δ
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.22%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-96.11%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.73%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
python/graphscope/tests/unittest/test_context.py 0.00% <0.00%> (-81.04%) ⬇️
python/graphscope/analytical/udf/wrapper.py 27.27% <0.00%> (-72.73%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0662ac...de05d7e. Read the comment docs.

@siyuan0322 siyuan0322 changed the title Zsy/groot log Some minor improvement in logs and configurations of groot. Jan 4, 2023
@siyuan0322 siyuan0322 merged commit 83c0298 into alibaba:main Jan 4, 2023
@siyuan0322 siyuan0322 deleted the zsy/groot-log branch January 4, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants