[GIE/Physical] Introduce new physical operators (in proto) and physical plan builder #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BingqingLyu
force-pushed
the
ir_physical
branch
from
a4e9cdc
to
9920b6c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
===========================================
- Coverage 72.01% 39.93% -32.09%
===========================================
Files 88 88
Lines 10120 9771 -349
===========================================
- Hits 7288 3902 -3386
- Misses 2832 5869 +3037
Continue to review full report at Codecov.
|
BingqingLyu
force-pushed
the
ir_physical
branch
4 times, most recently
from
e80bf60
to
3c70789
Compare
longbinlai
reviewed
Feb 9, 2023
| } | ||
|
|
||
| // A dummy node to delegate a source opr for multiple scan cases. | ||
| message Dummy {} |
longbinlai
reviewed
Feb 9, 2023
| import "expr.proto"; | ||
| import "schema.proto"; | ||
| import "type.proto"; | ||
| import "algebra.proto"; |
There was a problem hiding this comment.
Suggest redefine those operators even they are the same as the logical ones.
BingqingLyu
force-pushed
the
ir_physical
branch
from
db120c1
to
fac34e5
Compare
longbinlai
reviewed
Feb 10, 2023
| PathExpand path = 32; | ||
| } | ||
| } | ||
| message ColumnType { |
BingqingLyu
force-pushed
the
ir_physical
branch
from
5e4a791
to
d6cc5a4
Compare
BingqingLyu
force-pushed
the
ir_physical
branch
from
8cd330e
to
dd6c2e0
Compare
longbinlai
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
#2417