[GAIA Compiler] Build algebra layer structures for graph operators #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
force-pushed
the
ir_algebra_tmp
branch
from
975a716
to
97dfa1f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
=======================================
Coverage 39.93% 39.93%
=======================================
Files 88 88
Lines 9771 9771
=======================================
Hits 3902 3902
Misses 5869 5869 Continue to review full report at Codecov.
|
longbinlai
reviewed
Feb 22, 2023
| GraphOpt.GetV.END, | ||
| new LabelConfig(false).addLabel("person"))) | ||
| .range(1, 3) | ||
| .pathOpt(PathOpt.Simple) |
There was a problem hiding this comment.
PathOpt和ResultOpt可否也统一到GraphOpt.PathExpand.Simple和 GraphOpt.PathExpand.AllV ?
There was a problem hiding this comment.
PathOpt和ResultOpt还是要区分开，GraphOpt里加了PathExpandPath和PathExpandResult
longbinlai
reviewed
Feb 23, 2023
| public TableConfig(List<RelOptTable> tables) { | ||
| this.tables = ObjectUtils.requireNonEmpty(tables); | ||
| ; | ||
| this.isAll = false; |
There was a problem hiding this comment.
Please fix code format issue.
longbinlai
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
com.alibaba.graphscope.common.ir.schema)com.alibaba.graphscope.common.ir.type)Related issue number
Fixes