[GAIA Compiler] Build algebra layer structures for expressions #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longbinlai
reviewed
Feb 27, 2023
| } catch (IllegalArgumentException e) { | ||
| return; | ||
| } | ||
| Assert.fail("tag 'a' should not exist"); |
There was a problem hiding this comment.
tag 'a' does not exist is a better description.
longbinlai
reviewed
Feb 27, 2023
| public void equal_plus_test() { | ||
| RexNode var = builder.source(mockSourceConfig("a")).variable("a", "age"); | ||
| RexNode plus = builder.call(GraphStdOperatorTable.PLUS, var, builder.literal(10)); | ||
| RexNode equal = builder.call(GraphStdOperatorTable.EQUALS, plus, builder.literal(30)); |
There was a problem hiding this comment.
According to your comment, this should be GreaterThan ?
There was a problem hiding this comment.
the comment is fixed
longbinlai
reviewed
Feb 27, 2023
| @@ -76,7 +76,7 @@ | |||
| "comment": "name" | |||
| }, | |||
| { | |||
| "id": 3, | |||
| "id": 4, | |||
There was a problem hiding this comment.
Why these ids changed?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
===========================================
- Coverage 73.22% 39.95% -33.27%
===========================================
Files 88 88
Lines 9769 9769
===========================================
- Hits 7153 3903 -3250
- Misses 2616 5866 +3250
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
variable(..)inGraphBuilder.javato build algebra layer structures for expressions.NameOrIdto denote property key as name or id inRexGraphVariable.Related issue number
Fixes