Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE] impl graph_proxy for csr_store #2466

Merged
merged 54 commits into from Mar 21, 2023
Merged

[GIE] impl graph_proxy for csr_store #2466

merged 54 commits into from Mar 21, 2023

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Feb 27, 2023

Related issue number

Fixes #2465

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #2466 (f396210) into main (8b4103f) will increase coverage by 32.69%.
The diff coverage is 53.84%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2466       +/-   ##
===========================================
+ Coverage   39.88%   72.57%   +32.69%     
===========================================
  Files          88       88               
  Lines        9814     9838       +24     
===========================================
+ Hits         3914     7140     +3226     
+ Misses       5900     2698     -3202     
Impacted Files Coverage Δ
python/graphscope/client/session.py 75.88% <ø> (+10.09%) ⬆️
...on/graphscope/tests/kubernetes/test_demo_script.py 72.15% <50.00%> (-3.50%) ⬇️
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/deploy/kubernetes/cluster.py 76.19% <100.00%> (ø)

... and 46 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ecefc...f396210. Read the comment docs.

@lnfjpt lnfjpt force-pushed the main branch 2 times, most recently from eed91c5 to b3584ac Compare March 9, 2023 02:03
@lnfjpt lnfjpt changed the title [WIP] impl graph_proxy for csr_store [GIE] impl graph_proxy for csr_store Mar 10, 2023
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still many copyrights are missing.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can include some unit tests.

@lnfjpt lnfjpt force-pushed the main branch 6 times, most recently from b2a101c to a14fb60 Compare March 20, 2023 08:54
@lnfjpt lnfjpt merged commit 8a215c3 into alibaba:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GIE] Implement graph_proxy for csr_store
5 participants