Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE/Runtime] Sink all tagged columns as default if no tags given in Sink #2489

Merged
merged 6 commits into from Mar 13, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Mar 6, 2023

What do these changes do?

To be compatible with Cypher, we extend Sink in runtime by:

  1. Sink all tagged columns as default if no tags given in Sink
  2. Sink tags by the format of ID (tag's id) if no TagId->TagName mappings provided

Related issue number

Fixes #2488

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #2489 (3772f45) into main (4f5bbeb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2489   +/-   ##
=======================================
  Coverage   39.87%   39.87%           
=======================================
  Files          88       88           
  Lines        9816     9816           
=======================================
  Hits         3914     3914           
  Misses       5902     5902           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5bbeb...3772f45. Read the comment docs.

@BingqingLyu BingqingLyu merged commit 5bb5d84 into alibaba:main Mar 13, 2023
@BingqingLyu BingqingLyu deleted the ir_sink_refine branch March 13, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GIE/Runtime] Sink all tagged columns as default if no tags given in Sink
3 participants