-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GIE] Support Until
condition in PathExpand
#2514
Merged
BingqingLyu
merged 27 commits into
alibaba:main
from
shirly121:ir_path_expand_condition
Mar 29, 2023
Merged
[GIE] Support Until
condition in PathExpand
#2514
BingqingLyu
merged 27 commits into
alibaba:main
from
shirly121:ir_path_expand_condition
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5599b3c.
This reverts commit 5599b3c.
…Scope into ir_path_expand_condition
…21/GraphScope into ir_path_expand_condition
This reverts commit 8c58985.
BingqingLyu
force-pushed
the
ir_path_expand_condition
branch
4 times, most recently
from
March 14, 2023 07:03
ffad253
to
573b44b
Compare
BingqingLyu
force-pushed
the
ir_path_expand_condition
branch
from
March 14, 2023 07:39
573b44b
to
8f76864
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
=======================================
Coverage 39.90% 39.90%
=======================================
Files 88 88
Lines 9838 9838
=======================================
Hits 3926 3926
Misses 5912 5912 Continue to review full report in Codecov by Sentry.
|
This reverts commit 7986e0b.
BingqingLyu
force-pushed
the
ir_path_expand_condition
branch
from
March 22, 2023 07:35
288e2b1
to
2152200
Compare
BingqingLyu
force-pushed
the
ir_path_expand_condition
branch
from
March 22, 2023 07:40
2152200
to
9258359
Compare
longbinlai
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Support
UNTIL
condition inPathExpand
. e.g., you can query like:1)
g.V().hasLabel('person').has('name', 'marko').out("0..10").with('UNTIL', '@.name=='josh'')
,which means to find the path starting from 'marko', and ends if the target vertex is 'josh', or the path's length exceeds 10.
2)
g.V().hasLabel('person').has('name', 'marko').out("5..10").with('UNTIL', '@.name=='josh'')
,which means to find the path starting from 'marko', the path's length must be no less than 5, and ends either the target vertex is 'josh', or the path's length exceeds 10.
3)
g.V().hasLabel('person').has('name', 'marko').out("1..10").with('UNTIL', '@.name=='marko'')
,which means to find the path starting from 'marko', and ends if the target vertex is 'marko' (i.e., a cycle detection), or the path's length exceeds 10. NOTICE that in this case, DO NOT give the lower bound as
0
. If0
is given, the path will stop immediately at the starting 'marko' vertex since it already meets the until condition.Related issue number
Fixes #2516