Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix bug in getting properties with LateProject strategy #2534

Merged
merged 14 commits into from
Mar 22, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Mar 20, 2023

What do these changes do?

  1. Fix bug in getting properties with LateProject strategy by supporting get_property (e.g., when for IdOnlyVertex), and get_all_property from storage directly when necessary.
  2. Modify the logic in LazyDetails, that when get_all_property(), we do get all properties from the store vertex, instead of getting all pre-cached properties from the runtime vertex. However, when encoding the LazyDetails, it will carry the pre-cached properties, since we want to visit these properties on remote partitions.
  3. Remove hybrid_details when GIE on Groot, as it is not necessary in LateProject strategy.

Related issue number

Fixes #2535

@BingqingLyu BingqingLyu marked this pull request as draft March 20, 2023 02:54
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #2534 (8d74b74) into main (4bf57ce) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   39.90%   39.90%           
=======================================
  Files          88       88           
  Lines        9838     9838           
=======================================
  Hits         3926     3926           
  Misses       5912     5912           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf57ce...8d74b74. Read the comment docs.

@BingqingLyu BingqingLyu marked this pull request as ready for review March 20, 2023 08:02
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit 051e78f into alibaba:main Mar 22, 2023
@BingqingLyu BingqingLyu deleted the bug_fix branch March 22, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] get properties failed in GIE with LateProject strategy
4 participants