-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Fix bug in getting properties with LateProject
strategy
#2534
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=======================================
Coverage 39.90% 39.90%
=======================================
Files 88 88
Lines 9838 9838
=======================================
Hits 3926 3926
Misses 5912 5912 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
IdOnlyVertex
), and get_all_property from storage directly when necessary.LazyDetails
, that when get_all_property(), we do get all properties from the store vertex, instead of getting allpre-cached
properties from the runtime vertex. However, when encoding theLazyDetails
, it will carry thepre-cached
properties, since we want to visit these properties on remote partitions.LateProject
strategy.Related issue number
Fixes #2535