Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE] Integrate the FLASH model with GraphScope #2554

Merged
merged 1 commit into from Apr 12, 2023

Conversation

lixueclaire
Copy link
Collaborator

What do these changes do?

FLASH is a distributed programming model with strong expressiveness. It provides flexible control flow, the operations on arbitrary vertex sets and beyond-neighborhood communication, thus makes diverse complex graph algorithms easy to write at the distributed runtime.
This change implements the FLASH model by utilizing the ability of parallel computing and communication of GraphScope GAE, and provides more than 70 built-in graph algorithms with FLASH model. These algorithms could be triggered from Python client of GraphScope.

Related issue number

#2553

@acezen acezen self-requested a review March 24, 2023 02:11
analytical_engine/apps/flash/centrality/bc.h Outdated Show resolved Hide resolved
analytical_engine/apps/flash/centrality/bc.h Outdated Show resolved Hide resolved
analytical_engine/apps/flash/centrality/harmonic.h Outdated Show resolved Hide resolved
analytical_engine/apps/flash/clustering/clustering-coeff.h Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #2554 (49e596b) into main (0d6bedb) will increase coverage by 1.53%.
The diff coverage is 76.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2554      +/-   ##
==========================================
+ Coverage   39.90%   41.43%   +1.53%     
==========================================
  Files          88       99      +11     
  Lines        9838    10273     +435     
==========================================
+ Hits         3926     4257     +331     
- Misses       5912     6016     +104     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_flash.py 0.00% <0.00%> (ø)
python/graphscope/tests/conftest.py 48.36% <40.00%> (-0.13%) ⬇️
python/graphscope/analytical/app/flash/ranking.py 61.53% <61.53%> (ø)
python/graphscope/analytical/app/flash/subgraph.py 74.13% <74.13%> (ø)
python/graphscope/analytical/app/flash/core.py 76.00% <76.00%> (ø)
...hon/graphscope/analytical/app/flash/measurement.py 76.00% <76.00%> (ø)
...on/graphscope/analytical/app/flash/connectivity.py 76.56% <76.56%> (ø)
python/graphscope/analytical/app/flash/matching.py 77.08% <77.08%> (ø)
...ython/graphscope/analytical/app/flash/traversal.py 77.50% <77.50%> (ø)
...thon/graphscope/analytical/app/flash/clustering.py 78.57% <78.57%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f44323...49e596b. Read the comment docs.

@lixueclaire
Copy link
Collaborator Author

Hi @acezen, I've made some updates based on your comments and modified the Python tests to fix a CI bug. Could you please review the newest version of the code and let me know if you have additional comments?

@acezen acezen changed the title [WIP][GAE] Integrate the FLASH model with GraphScope [GAE] Integrate the FLASH model with GraphScope Apr 11, 2023
Copy link
Collaborator

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen requested a review from yecol April 11, 2023 08:46
@yecol
Copy link
Collaborator

yecol commented Apr 11, 2023

👍🏻👍🏻👍🏻

@lixueclaire lixueclaire merged commit b8232ab into alibaba:main Apr 12, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants