Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] fix some bugs found in cypher e2e test #2579

Merged
merged 6 commits into from Mar 31, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Mar 31, 2023

What do these changes do?

Several bugs fixed, including:

  • In schema
  1. modern graph schema with a wrong label id;
  • In IrCore
  1. in pattern matching, when generating source opr, assign the proper table info.
  2. when processing PathExpand in pattern, throw the unsupported error for PathExpand ranging from 0, only when it is in the Intersection
  • In runtime
  1. do not throw error when GetV Opt is not EndV for path anymore, as this can be either StartV or EndV for now, according to the direction of EdgeExpand in PathExpand's ExpandBase.

Related issue number

Fixes

@codecov-commenter
Copy link

Codecov Report

Merging #2579 (febdf3d) into main (04d21ec) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2579   +/-   ##
=======================================
  Coverage   39.90%   39.90%           
=======================================
  Files          88       88           
  Lines        9838     9838           
=======================================
  Hits         3926     3926           
  Misses       5912     5912           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d21ec...febdf3d. Read the comment docs.

MeloYang05 and others added 3 commits March 31, 2023 17:36
…schema inferred label table

1. if user given label table is empty, use the schema inferred label table, and vice versa

2. if the two tables are both not empty, use the intersection of the two tables
@BingqingLyu BingqingLyu changed the title [Bug Fix] fix the bug in filtering by labels in GetV() when opt=Self [Bug Fix] fix some bugs found in cypher e2e test Mar 31, 2023
@BingqingLyu BingqingLyu merged commit 94eaf9c into alibaba:main Mar 31, 2023
24 checks passed
@BingqingLyu BingqingLyu deleted the bug_fix branch April 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants