Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIE/Runtime] Remove the dependency of GIE Runtime on GlobalQueryStore to accelerate the compilation #2681

Merged
merged 4 commits into from
May 10, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented May 9, 2023

What do these changes do?

As titled.

Notice that by default compiling (cargo build in ir-core), it won't depend on GlobalQuery anymore. If you want to compile GIE based on GlobalQuery (including Groot and V6d), do cargo build --features with_global_query.

Related issue number

Fixes #2679

@BingqingLyu BingqingLyu marked this pull request as draft May 9, 2023 07:15
@BingqingLyu BingqingLyu marked this pull request as ready for review May 10, 2023 01:56
Copy link
Collaborator

@siyuan0322 siyuan0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR only takes effect when compile ir on experimental store.

So if we do make interactive it still need to compile rocksdb twice..

Now I understand it's because the global_query is a interface like crate, which depends on rocksdb, which is not a decent design. Someday we may want to drop this dependency.

@BingqingLyu
Copy link
Collaborator Author

Seems this PR only takes effect when compile ir on experimental store.

So if we do make interactive it still need to compile rocksdb twice..

Now I understand it's because the global_query is a interface like crate, which depends on rocksdb, which is not a decent design. Someday we may want to drop this dependency.

Agreed. This is expected to be resolved after we introduced GRIN.

@codecov-commenter
Copy link

Codecov Report

Merging #2681 (eb27820) into main (b258999) will decrease coverage by 32.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2681       +/-   ##
===========================================
- Coverage   73.61%   41.48%   -32.14%     
===========================================
  Files          98       98               
  Lines       10317    10306       -11     
===========================================
- Hits         7595     4275     -3320     
- Misses       2722     6031     +3309     

see 55 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46663e...eb27820. Read the comment docs.

@BingqingLyu BingqingLyu merged commit 909b3c4 into alibaba:main May 10, 2023
24 checks passed
@BingqingLyu BingqingLyu deleted the remove_groot_dependency branch May 10, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the dependency of GIE Runtime on GlobalQueryStore to accelerate the compilation
3 participants