Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphProxy] refine implementation of LazyDetails #2766

Merged
merged 3 commits into from May 30, 2023

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented May 30, 2023

What do these changes do?

Refine implementation of LazyDetails to avoid memory leak.

Related issue number

Fixes

@BingqingLyu BingqingLyu marked this pull request as draft May 30, 2023 02:04
@BingqingLyu BingqingLyu marked this pull request as ready for review May 30, 2023 05:53
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #2766 (049fd9d) into main (4b24146) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2766   +/-   ##
=======================================
  Coverage   41.39%   41.39%           
=======================================
  Files          99       99           
  Lines       10381    10381           
=======================================
  Hits         4297     4297           
  Misses       6084     6084           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b24146...049fd9d. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BingqingLyu BingqingLyu merged commit 7fd430b into alibaba:main May 30, 2023
25 checks passed
@BingqingLyu BingqingLyu deleted the fix_lazy_details branch June 19, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants