Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groot schema now supports add comment #2802

Merged
merged 9 commits into from
Jun 5, 2023

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Jun 2, 2023

What do these changes do?

🤖 Generated by Copilot at 24f683e

This pull request adds the ability to add comments to the schema definition of graphs, labels, and properties in GraphScope. It modifies the TypeDef class and related classes in Java and Python, the model.proto and graph_def.proto files, and the ClientDdlService and SchemaManager classes. It also adds logging and error handling improvements and updates the test cases accordingly.

Related issue number

Fixes #2801

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #2802 (77f0755) into main (9efd4f6) will increase coverage by 37.53%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2802       +/-   ##
===========================================
+ Coverage   35.62%   73.15%   +37.53%     
===========================================
  Files          99       99               
  Lines       10518    10527        +9     
===========================================
+ Hits         3747     7701     +3954     
+ Misses       6771     2826     -3945     
Impacted Files Coverage Δ
.../graphscope/tests/kubernetes/test_store_service.py 0.00% <0.00%> (ø)
python/graphscope/tests/unittest/test_graph.py 86.24% <ø> (+86.24%) ⬆️
python/graphscope/framework/graph_schema.py 63.79% <61.90%> (+4.70%) ⬆️

... and 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efd4f6...77f0755. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 57b22fe into alibaba:main Jun 5, 2023
34 of 35 checks passed
@siyuan0322 siyuan0322 deleted the zsy/comment branch June 5, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make groot schema could carry comment.
2 participants