Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix bugs of time counter in gremlin service #2906

Merged
merged 17 commits into from Jul 7, 2023

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Jun 15, 2023

What do these changes do?

as titled

Related issue number

Fixes #2905

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #2906 (b446ede) into main (d12cd9a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   42.37%   42.37%           
=======================================
  Files          99       99           
  Lines       10649    10649           
=======================================
  Hits         4512     4512           
  Misses       6137     6137           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12cd9a...b446ede. Read the comment docs.

@shirly121
Copy link
Collaborator Author

shirly121 commented Jul 5, 2023

fix according to review suggestions, see 76fda65: @longbinlai

  1. rename locked to isContextWritable
  2. add QueryLogger to print log info per query

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbinlai longbinlai merged commit 7330954 into alibaba:main Jul 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inaccurate Execution Time Calculation in Gremlin Service's Time Counter
3 participants