[GIE Compiler] Support Case When Expression in Logical and Physical Plan #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2918 +/- ##
=======================================
Coverage 42.37% 42.37%
=======================================
Files 99 99
Lines 10649 10649
=======================================
Hits 4512 4512
Misses 6137 6137 Continue to review full report in Codecov by Sentry.
|
longbinlai
reviewed
Jun 21, 2023
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class GraphCaseOperator extends SqlOperator { |
There was a problem hiding this comment.
It is CaseOperator instead of GraphCaseOperator, as it is not a Graph operator.
longbinlai
reviewed
Jun 21, 2023
| public class CaseTest { | ||
| // case when a.name = 'marko' then 1 else 3 end | ||
| @Test | ||
| public void case_1_test() { |
There was a problem hiding this comment.
Add test of more than two branches
There was a problem hiding this comment.
more cases are added in interactive_engine/compiler/src/test/java/com/alibaba/graphscope/cypher/antlr4/WithTest.java
| @@ -124,6 +124,15 @@ message DynamicParam { | |||
| common.IrDataType data_type = 3; | |||
| } | |||
|
|
|||
| message Case { | |||
There was a problem hiding this comment.
message Case {
// Pair of when <expr> then <expr>
message WhenThen {
Expression when = 1;
Expression then = 2;
}
// A case operator always follows with a sequence of when_then pairs, e.g.
// CASE WHEN a.name == 'Marko' THEN 1
// WHEN a.name == 'John' THEN 2
repeated WhenThen when_thens = 1;
// The trailed else expression: ELSE 3
Expression else_result = 2;
}
longbinlai
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
as titled.
Related issue number
#2686