Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to frontend directly, bypass coordinator for GIE query #2923

Merged
merged 4 commits into from Jun 26, 2023

Conversation

siyuan0322
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

🎊 PR Preview 08b460b has been successfully built and deployed to https://alibaba-graphscope-build-pr-2923.surge.sh

🤖 By surge-preview

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Merging #2923 (a9eebed) into main (34b3650) will decrease coverage by 7.80%.
The diff coverage is 26.53%.

❗ Current head a9eebed differs from pull request most recent head 08b460b. Consider uploading reports for the commit 08b460b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
- Coverage   73.96%   66.17%   -7.80%     
==========================================
  Files          99       99              
  Lines       10672    10624      -48     
==========================================
- Hits         7894     7030     -864     
- Misses       2778     3594     +816     
Impacted Files Coverage Δ
python/graphscope/client/session.py 67.15% <ø> (-10.32%) ⬇️
python/graphscope/framework/dag_utils.py 64.37% <ø> (-3.34%) ⬇️
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-81.77%) ⬇️
python/graphscope/tests/minitest/test_min.py 0.00% <0.00%> (ø)
python/graphscope/interactive/query.py 67.16% <68.75%> (-19.59%) ⬇️
python/graphscope/framework/loader.py 82.94% <100.00%> (ø)
python/graphscope/tests/unittest/test_lazy.py 96.18% <100.00%> (-0.03%) ⬇️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b3650...08b460b. Read the comment docs.

format

rewrite .all() to .all().result()

update

fix

Committed-by: siyuanzhang.zsy from Dev container

fix

Committed-by: siyuanzhang.zsy from Dev container

update

Committed-by: siyuanzhang.zsy from Dev container

Committed-by: siyuanzhang.zsy from Dev container
Committed-by: siyuanzhang.zsy from Dev container

Committed-by: siyuanzhang.zsy from Dev container
Committed-by: siyuanzhang.zsy from Dev container
Committed-by: siyuanzhang.zsy from Dev container
@siyuan0322 siyuan0322 merged commit 25496f8 into alibaba:main Jun 26, 2023
39 of 42 checks passed
@siyuan0322 siyuan0322 deleted the zsy/frontend branch June 26, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants