Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GIE] Introduce Aggregate.First proto definition #2991

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[GIE] Introduce Aggregate.First proto definition #2991

merged 1 commit into from
Jul 10, 2023

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Jul 10, 2023 •
edited
Loading

Introduce Aggregate function First in to GroupBy operator.

Related issue: #2992

@longbinlai longbinlai linked an issue Jul 10, 2023 that may be closed by this pull request
Aggregate function First is need in GIE GroupBy operator #2992
Closed
longbinlai
longbinlai approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanglei1949 zhanglei1949 merged commit d10d17d into alibaba:main Jul 10, 2023
25 checks passed
@zhanglei1949 zhanglei1949 deleted the agg_first branch July 13, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longbinlai longbinlai longbinlai approved these changes

@luoxiaojian luoxiaojian luoxiaojian approved these changes

@BingqingLyu BingqingLyu Awaiting requested review from BingqingLyu

@shirly121 shirly121 Awaiting requested review from shirly121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregate function First is need in GIE GroupBy operator
3 participants
@zhanglei1949 @longbinlai @luoxiaojian