feat(interactive): Support Unfold step in GIE #3143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Add union+identity test && Identity e2e Test
Committed-by: Yunkai Lou from Dev container
remove std output in test
Committed-by: Yunkai Lou from Dev container
fix java format issues
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
longbinlai
reviewed
Aug 24, 2023
.gitignore
Outdated
| @@ -69,6 +69,7 @@ interactive_engine/gaia-adaptor/dependency-reduced-pom.xml | |||
| interactive_engine/executor/Cargo.lock | |||
| interactive_engine/executor/engine/pegasus/benchmark/src/graph/storage/clickhouse/pb_gen/* | |||
| interactive_engine/executor/ir/Cargo.lock | |||
| interactive_engine/compiler/core | |||
There was a problem hiding this comment.
This is not necessary.
| @@ -0,0 +1,3399 @@ | |||
| // | |||
| //! Copyright 2020 Alibaba Group Holding Limited. | |||
There was a problem hiding this comment.
this file should not be included.
| @LoadGraphWith(LoadGraphWith.GraphData.MODERN) | ||
| @Test | ||
| public void g_V_fold_a_unfold_values() { | ||
| Traversal<Vertex, Object> traversal = this.get_g_V_fold_a_unfold_values(); |
There was a problem hiding this comment.
Can we check whether the tag a is still in the record of the unfolded results?
add test
Committed-by: Yunkai Lou from Dev container
Committed-by: Yunkai Lou from Dev container
Change test file
Committed-by: Yunkai Lou from Dev container
remove unfold op test
Committed-by: Yunkai Lou from Dev container
remove logical.rs.orig
longbinlai
previously approved these changes
Aug 29, 2023
Committed-by: Yunkai Lou from Dev container
add the optimization about select.as.unfold as a strategy
shirly121
previously approved these changes
Aug 31, 2023
| // System.out.println(step); | ||
| // System.out.println(opList); | ||
| // System.out.println(step.getLabels()); | ||
|
|
There was a problem hiding this comment.
是否可以将这段代码实现为一个strategy？我理解这里做的事情是将select('a').unfold()的组合转换为unfold(tag='a')，这个看起来更适合实现为strategy，具体可以参考实现https://github.com/alibaba/GraphScope/blob/main/interactive_engine/compiler/src/main/java/com/alibaba/graphscope/common/intermediate/strategy/TopKStrategy.java
...e_engine/compiler/src/main/java/com/alibaba/graphscope/gremlin/InterOpCollectionBuilder.java
Outdated
Show resolved
Hide resolved
Committed-by: Yunkai Lou from Dev container
java format
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3143 +/- ##
==========================================
- Coverage 42.29% 42.05% -0.24%
==========================================
Files 101 101
Lines 10907 10985 +78
==========================================
+ Hits 4613 4620 +7
- Misses 6294 6365 +71
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Committed-by: Yunkai Lou from Dev container
cancel optimization for select.as.unfold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
support Unfold step in GIE
Related issue number
#3129
Fixes