New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(interactive): Parse Graph Schema from Yaml Configuration #3145
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
===========================================
- Coverage 73.25% 42.29% -30.96%
===========================================
Files 102 101 -1
Lines 11006 10907 -99
===========================================
- Hits 8062 4613 -3449
- Misses 2944 6294 +3350 see 62 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@longbinlai infer file format from its content instead of extension: 4d33e52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse interactive's default graph.yaml in interactive dierectory, rather than creating a new file only for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems reasonable to keep them in src/test/resources.
e893ddd
What do these changes do?
Related issue number
Fixes