Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix the bug in the RexNode to Proto Conversion #3171

Merged
merged 4 commits into from
Sep 4, 2023

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

For a specific expression, i.e. a.age-(b.age-1), there is an issue when converting it to a proto structure, resulting in missing parentheses in the generated proto; it gets converted to a.age-b.age-1. This PR is meant to address the issue.

Related issue number

Fixes

Copy link
Collaborator

@zhanglei1949 zhanglei1949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #3171 (c9483e9) into main (246f85b) will decrease coverage by 30.96%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3171       +/-   ##
===========================================
- Coverage   73.25%   42.29%   -30.96%     
===========================================
  Files         102      101        -1     
  Lines       11006    10907       -99     
===========================================
- Hits         8062     4613     -3449     
- Misses       2944     6294     +3350     

see 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9dcbe6...c9483e9. Read the comment docs.

@longbinlai longbinlai merged commit 2d1d139 into alibaba:main Sep 4, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants