refactor(interactive): Support DateFormats in GIE Runtime #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BingqingLyu
force-pushed
the
ir_date_formats
branch
from
9084c62
to
2eaf0dd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3197 +/- ##
===========================================
- Coverage 72.55% 42.05% -30.50%
===========================================
Files 102 101 -1
Lines 11086 10985 -101
===========================================
- Hits 8043 4620 -3423
- Misses 3043 6365 +3322 see 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
BingqingLyu
changed the title
longbinlai
reviewed
Sep 7, 2023
| @@ -37,6 +38,10 @@ pub enum RawType { | |||
| ULLong, | |||
| Float, | |||
| String, | |||
| DateFormat, | |||
There was a problem hiding this comment.
Date instead of DateFormat, and applies to the follows.
longbinlai
reviewed
Sep 7, 2023
| @@ -409,13 +414,194 @@ impl PartialOrd for Primitives { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug, Hash)] | |||
| pub enum DateFormats { | |||
There was a problem hiding this comment.
Seem like should be DateTimeFormats ?
longbinlai
approved these changes
Sep 7, 2023
Zhanghyi
pushed a commit
to Zhanghyi/GraphScope
that referenced
this pull request
Sep 8, 2023
<!-- Thanks for your contribution! please review https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before opening an issue. --> ## What do these changes do? <!-- Please give a short brief about these changes. --> As titled. ## Related issue number <!-- Are there any issues opened that will be resolved by merging this change? --> Fixes alibaba#3179 Committed-by: Hongyi ZHANG from Dev container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
As titled.
Related issue number
Fixes #3179