Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Integrate Gremlin Into New Compilation Stack #3332

Merged
merged 39 commits into from
Feb 5, 2024

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Nov 7, 2023

What do these changes do?

Supported Steps are listed in #3136

Related issue number

Fixes

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9228223) 48.81% compared to head (d586829) 27.89%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3332       +/-   ##
===========================================
- Coverage   48.81%   27.89%   -20.93%     
===========================================
  Files         177      176        -1     
  Lines       16198    16168       -30     
===========================================
- Hits         7907     4510     -3397     
- Misses       8291    11658     +3367     

see 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c8d15...d586829. Read the comment docs.

@shirly121 shirly121 marked this pull request as ready for review December 18, 2023 09:41
@longbinlai longbinlai changed the title fix(interactive): Integrate Gremlin Into Calcite Stack fix(interactive): Integrate Gremlin Into New Compilation Stack Jan 9, 2024
@shirly121
Copy link
Collaborator Author

@longbinlai rename child count of traversal predicates in 7530661

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit 623fbf0 into alibaba:main Feb 5, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants