Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Check vertex existence whenever queried #3343

Merged
merged 2 commits into from Nov 13, 2023

Conversation

siyuan0322
Copy link
Collaborator

Previously, when query a vertex by pk, it doesn't check whether the vertex exists.

g.V().has('person', 'id', 1)

This PR will do a lookup in the database and return empty if not exists.

@siyuan0322 siyuan0322 changed the title Check vertex existence whenever queried fix(interactive): Check vertex existence whenever queried Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3343 (43a1766) into main (1a317bf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3343   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files         109      109           
  Lines       11298    11298           
=======================================
  Hits         4637     4637           
  Misses       6661     6661           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a317bf...43a1766. Read the comment docs.

@siyuan0322 siyuan0322 merged commit d386676 into alibaba:main Nov 13, 2023
28 of 29 checks passed
@siyuan0322 siyuan0322 deleted the zsy/pk-get branch November 13, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants