feat(interactive): Add Rate Limiter for Control Flow #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3368 +/- ##
=======================================
Coverage 41.04% 41.04%
=======================================
Files 109 109
Lines 11298 11298
=======================================
Hits 4637 4637
Misses 6661 6661 Continue to review full report in Codecov by Sentry.
|
shirly121
changed the title
siyuan0322
reviewed
Nov 22, 2023
| @@ -45,4 +45,7 @@ public class FrontendConfig { | |||
|
|
|||
| public static final Config<Integer> QUERY_CACHE_SIZE = | |||
| Config.intConfig("query.cache.size", 100); | |||
|
|
|||
| public static final Config<Integer> QUERY_PER_SECOND_LIMIT = | |||
| Config.intConfig("query.per.second.limit", 100); | |||
There was a problem hiding this comment.
By default there should be no limit, or set it to a value that large enough.
longbinlai
reviewed
Nov 22, 2023
docs/storage_engine/groot.md
Outdated
| @@ -74,6 +75,7 @@ helm status demo | |||
| | ingestor.replicaCount | Number of Ingestor Pod | 2 | | |||
| | frontend.service.type | Kubernetes Service type of frontend | NodePort | | |||
| | dataset.modern | Load [modern graph](https://tinkerpop.apache.org/docs/current/tutorials/getting-started/) dataset at the start | false | | |||
| | query.per.second.limit | the maximum qps can be handled by frontend service | 2147483647 (without limitation) | | |||
There was a problem hiding this comment.
这个加frontend 前缀吧。frontend.query.per.second.limit , 然后把frontend前缀的几个项目都整合到一起吧。
siyuan0322
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Fixes