refactor(interactive): Improve the code of checking if a given label sets contain all labels in the schema #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BingqingLyu
reviewed
Nov 23, 2023
| @@ -1502,7 +1504,7 @@ fn is_params_all_labels(params: &pb::QueryParams) -> bool { | |||
| .as_ref() | |||
| .and_then(|store_meta| store_meta.schema.as_ref()) | |||
| { | |||
| let params_label_ids: BTreeSet<LabelId> = params | |||
| let params_label_ids: Vec<LabelId> = params | |||
There was a problem hiding this comment.
Params may carry duplicated tables in Gremlin for now. e.g., g.V().hasLabel("PERSON","PERSON","SOFTWARE"),
params.tables will contain duplicated label ids of 1, representing "PERSON".
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
=======================================
Coverage 41.04% 41.04%
=======================================
Files 109 109
Lines 11298 11298
=======================================
Hits 4637 4637
Misses 6661 6661 Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of checking if a given label sets contain all labels in the schema