Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): event message error #3380

Merged
merged 4 commits into from Dec 1, 2023
Merged

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Nov 27, 2023

What do these changes do?

Related issue number

Fixes
#3177

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Merging #3380 (e01df8d) into main (c237328) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3380   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files         109      109           
  Lines       11298    11298           
=======================================
  Hits         4637     4637           
  Misses       6661     6661           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c237328...e01df8d. Read the comment docs.

@lnfjpt lnfjpt changed the title fix event message error fix(interactive): event message error Nov 28, 2023
@lnfjpt lnfjpt requested a review from bmmcq November 28, 2023 10:59
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend a new status (instead of reusing the NotReady status) for worker, indicating that this worker has finished its own job but just been waiting for the others to complete. How about, "AwaitingFinSync" ?

@siyuan0322 siyuan0322 merged commit d1d53f2 into alibaba:main Dec 1, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants