Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): fix unexpect result of operator aggregate() + iterate() #3391

Merged
merged 2 commits into from Dec 1, 2023

Conversation

lnfjpt
Copy link
Collaborator

@lnfjpt lnfjpt commented Nov 30, 2023

What do these changes do?

Related issue number

Fixes
#3177
Query2

@siyuan0322 siyuan0322 changed the title fix(interactive) fix unexpect result of operator aggregate() + iterate() fix(interactive): fix unexpect result of operator aggregate() + iterate() Nov 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3391 (00d8456) into main (608f814) will decrease coverage by 0.02%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3391      +/-   ##
==========================================
- Coverage   41.04%   41.02%   -0.02%     
==========================================
  Files         109      109              
  Lines       11298    11304       +6     
==========================================
+ Hits         4637     4638       +1     
- Misses       6661     6666       +5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7d88c...00d8456. Read the comment docs.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably set partitions of leave steam as the maximum partitions of input steam and feedback steam.

@siyuan0322 siyuan0322 merged commit 901b743 into alibaba:main Dec 1, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants