Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Start Time Metric in Compiler Log #3393

Merged
merged 1 commit into from Dec 1, 2023

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

Use System.currentTimeMillis() to obtain the start time of a query execution, instead of System.nanoTime(). The latter should only be used to calculate elapsed time and is not related to any other notion of system or wall-clock time.

Related issue number

Fixes

@codecov-commenter
Copy link

Codecov Report

Merging #3393 (b69813a) into main (85a42a8) will decrease coverage by 29.49%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3393       +/-   ##
===========================================
- Coverage   70.51%   41.02%   -29.49%     
===========================================
  Files         110      109        -1     
  Lines       11323    11304       -19     
===========================================
- Hits         7984     4638     -3346     
- Misses       3339     6666     +3327     

see 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a42a8...b69813a. Read the comment docs.

@siyuan0322 siyuan0322 merged commit 300d921 into alibaba:main Dec 1, 2023
29 checks passed
@siyuan0322 siyuan0322 deleted the ir_fix_time_log branch December 1, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants