fix(interactive): Convert Label Condition to Type Constraint #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3441 +/- ##
=======================================
Coverage 40.90% 40.90%
=======================================
Files 109 109
Lines 11343 11343
=======================================
Hits 4640 4640
Misses 6703 6703 Continue to review full report in Codecov by Sentry.
|
longbinlai
reviewed
Dec 19, 2023
| public void push_filter_5_test() { | ||
| RelNode node = | ||
| com.alibaba.graphscope.cypher.antlr4.Utils.eval( | ||
| "Match (a)-[b]-(c:person) Where labels(a)='person' and a.name =" |
There was a problem hiding this comment.
这里缺少一个type(a) = 'xx'，以及判断边类型的case.
There was a problem hiding this comment.
add end-to-end tests in c8a94cd
longbinlai
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
as titled.
Related issue number
Fixes #3378