-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(interactive): Fix bugs When Counting on Multiple Columns #3442
Conversation
com.alibaba.graphscope.cypher.antlr4.Utils.eval( | ||
"Match (a) Return count(distinct a.name, a.age)") | ||
.build(); | ||
System.out.println(node.getRowType()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
尽量assert而不是print。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 5bf01aa
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
=======================================
Coverage 40.90% 40.90%
=======================================
Files 109 109
Lines 11343 11343
=======================================
Hits 4640 4640
Misses 6703 6703 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
as titled.
Related issue number
Fixes #3410