Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flex): Fix warning when compiling with AOCC compilers #3510

Merged
merged 12 commits into from
Feb 6, 2024

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Jan 25, 2024

Remove some unused code, resolve all compilation warning when compile with AOCC/clang compilers.

Fix #3508

@@ -80,7 +80,8 @@ if (APPLE)
set(CMAKE_MACOSX_RPATH ON)
else ()
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp -Wl,-rpath,$ORIGIN -lopen-pal")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move -lopen-pal to ${CMAKE_EXEC_LINKER_FLAGS} resolves the warning

no `-lopen-pal: 'linker' input unused [-Wunused-command-line-argument]` 

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Werror

add aocc compilation test

sudo privilege

fix

fix
@zhanglei1949 zhanglei1949 changed the title fix(flex): Fix warning when compiler with AOCC/clang compilers fix(flex): Fix warning when compiler with AOCC compilers Feb 6, 2024
@zhanglei1949 zhanglei1949 changed the title fix(flex): Fix warning when compiler with AOCC compilers fix(flex): Fix warning when compiling with AOCC compilers Feb 6, 2024
@zhanglei1949 zhanglei1949 merged commit 7272b6b into alibaba:main Feb 6, 2024
37 checks passed
@zhanglei1949 zhanglei1949 deleted the cmake-option branch May 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interactive: Fix the warning of flex compilation
3 participants