-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flex): Fix warning when compiling with AOCC
compilers
#3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhanglei1949
commented
Jan 25, 2024
@@ -80,7 +80,8 @@ if (APPLE) | |||
set(CMAKE_MACOSX_RPATH ON) | |||
else () | |||
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fopenmp -Wl,-rpath,$ORIGIN -lopen-pal") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move -lopen-pal
to ${CMAKE_EXEC_LINKER_FLAGS}
resolves the warning
no `-lopen-pal: 'linker' input unused [-Wunused-command-line-argument]`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Werror add aocc compilation test sudo privilege fix fix
zhanglei1949
force-pushed
the
cmake-option
branch
from
February 4, 2024 07:12
eb7a836
to
48b81d8
Compare
zhanglei1949
changed the title
fix(flex): Fix warning when compiler with
fix(flex): Fix warning when compiler with Feb 6, 2024
AOCC/clang
compilersAOCC
compilers
luoxiaojian
approved these changes
Feb 6, 2024
zhanglei1949
changed the title
fix(flex): Fix warning when compiler with
fix(flex): Fix warning when compiling with Feb 6, 2024
AOCC
compilersAOCC
compilers
LiSu
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unused code, resolve all compilation warning when compile with AOCC/clang compilers.
Fix #3508