Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Bugs of Group Returning Results from Compiler #3533

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Feb 4, 2024

What do these changes do?

Group Returning Results are split into multiple maps in user scenarios, for the query which results size is larger than 64 can trigger the issue, i.e.

gremlin> g.V().hasLabel('PERSON').limit(100).group().by('firstName').by(count())
==>{Dặng Dinh=1, Carey=1, Michel=1, Wojciech=1, Ayesha=2, Anand=2, Franz=1, Volodymyr=1, Maria=1, Fritz=1, Jie=1, Kunal=1, Aditya=1, Mikhail=1, Milan=1, Serghei=1, Neil=1, Shweta=2, Walter=1, Arturo=1, Rahul=2, Barney=1, Peter=2, Evgeny=1, Charlie=1, Bing=1, Bob=1, Pope=1, Wilson=1, Arjun=1, Antonio=3, Carlos=2, Dania=1, André=1, K.=2, Crown Prince=1, Li=1, Karl=1, Gabriel=1, Javed=1, Michael=1, Asim=1, James=1, Alexander=2, Bela=1, Chipo=1, Philippe=1, Jun=2, Andry=1, Wei=2, Bingbing=1, Andrew=1, Yang=2, Abdala=1, Hao=1, Aa Ngurah=1, Mohammad Reza=1, Eddie=1, Luis=1, Lei=1, Zheng=1, Giuseppe=1, Dhafer=1, David=1}
==>{John=3, Ricky=1, Peng=1, A.=1, Ivan=1, Abdel Wahab=1, Chen=4, Sam=1, Boris=1, Mario=1, Lin=1, Paresh=1, Jose=1, Fernando=1, Almira=1, Abraham=1, R.=1, Ai=1}

This pr mainly fix the issue.

Related issue number

Fixes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9228223) 48.81% compared to head (3e53c18) 27.89%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3533       +/-   ##
===========================================
- Coverage   48.81%   27.89%   -20.93%     
===========================================
  Files         177      176        -1     
  Lines       16198    16168       -30     
===========================================
- Hits         7907     4510     -3397     
- Misses       8291    11658     +3367     

see 61 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9228223...3e53c18. Read the comment docs.

longbinlai
longbinlai previously approved these changes Feb 5, 2024
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siyuan0322 siyuan0322 merged commit 1828d42 into alibaba:main Feb 8, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants