Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix test_gremlin_timeout in Python Unit Tests #3536

Merged
merged 5 commits into from Feb 7, 2024

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

as titled.

Related issue number

Fixes #3480

Copy link
Collaborator

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks for the fix!

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87c4c75) 27.89% compared to head (1ec5a1b) 45.37%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3536       +/-   ##
===========================================
+ Coverage   27.89%   45.37%   +17.48%     
===========================================
  Files         176      176               
  Lines       16168    16167        -1     
===========================================
+ Hits         4510     7336     +2826     
+ Misses      11658     8831     -2827     
Files Coverage Δ
python/graphscope/tests/unittest/test_lazy.py 96.45% <ø> (+96.45%) ⬆️

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7272b6b...1ec5a1b. Read the comment docs.

@shirly121 shirly121 merged commit d8d1ac3 into alibaba:main Feb 7, 2024
25 of 27 checks passed
@shirly121 shirly121 deleted the ir_fix_timeout branch March 13, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] interactive unit test test_gremlin_timeout run failed in CI/CD
4 participants