fix(interactive): Fix CI Bug Caused By PR #3630 #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirly121
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
=======================================
Coverage 25.96% 25.96%
=======================================
Files 187 187
Lines 17379 17379
=======================================
Hits 4513 4513
Misses 12866 12866 Continue to review full report in Codecov by Sentry.
|
siyuan0322
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The issue is caused by PR #3630, which changed the result collection from asynchronous to synchronous. After submitting a request to the client, it is necessary to actively call a request to retrieve the result from the buffer. However, the test chain forgot to add this call, leading to the problem. This PR mainly fix the issue.
Related issue number
Fixes