Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(interactive): Fix Bugs of count() in Gremlin Based on Calcite-IR Layer #3751

Merged
merged 8 commits into from
May 6, 2024

Conversation

shirly121
Copy link
Collaborator

What do these changes do?

as titled.

Related issue number

#3731

Fixes

@shirly121 shirly121 changed the title fix(interactive): Fix Bugs of Count Star in Gremlin Based on Calcite-IR Layer fix(interactive): Fix Bugs of count() in Gremlin Based on Calcite-IR Layer Apr 25, 2024
@shirly121 shirly121 closed this Apr 25, 2024
@shirly121 shirly121 reopened this Apr 25, 2024
BingqingLyu
BingqingLyu previously approved these changes Apr 26, 2024
Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个count的实现不太合理,应该是count所有columns,而不是临时给一个head,再count这个head, 这个应该在group by, distinct场景里也有这个情况,需要统一看看如何fix

@shirly121 shirly121 merged commit 43c04de into alibaba:main May 6, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants