Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Implement attribute assortativity app and numeric assortativity app #515

Merged
merged 42 commits into from
Sep 22, 2021

Conversation

Ningsir
Copy link
Contributor

@Ningsir Ningsir commented Jul 12, 2021

What do these changes do?

Implement attribute assortativity coefficient app and numeric assortativity coefficient.

  • implement C++ PIE app with analytical engineAPI;
  • check the correctness with NetworkX
  • check the scalability and performance in large graph, like com-friendster dataset
  • add to python built-in algorithms and add related test case

Related issue number

#453

Experiment

attribute assortativity coefficient

Time GraphScope NetworkX
Twitter 0.58 S 1.32 S
datagen-7_5-fb 110 S 1028.03 S
datagen-7_7-zf 130 S 1048.43 S
datagen-8_0-fb 198.85 S 1899.76 S
Memory Usage
Twitter 0.64 G 0.71 G
datagen-7_5-fb 9.6 G 16.35 G
datagen-7_7-zf 27.2 G 26.01 G
datagen-8_0-fb 30.72 G 28.41 G

numeric assortativity coefficient

Time GraphScope NetworkX
Twitter 0.58 S 1.51 S
datagen-7_5-fb 101.52 S 188.64 S
datagen-7_7-zf 134.13 S 110.27 S
datagen-8_0-fb 219.91 S OOM
Memory Usage
Twitter 0.96 G 0.71 G
datagen-7_5-fb 11.20 G 17.75 G
datagen-7_7-zf 25 G 27.56 G
datagen-8_0-fb 31 G OOM

@yecol
Copy link
Collaborator

yecol commented Jul 12, 2021

@Ningsir Thanks for your commit!
Please assign the related issue in the abstract.

@yecol yecol added this to In progress in NetworkX compatibility Jul 20, 2021
@Ningsir Ningsir changed the title [WIP]Implement attribute assortativity app with cpp [WIP]Implement attribute assortativity app and numeric assortativity app Aug 9, 2021
@acezen acezen self-requested a review September 5, 2021 08:41
Copy link
Collaborator

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we nedd numeric_assortativity.h, seems we can reuse the attribute_assortativity.h, please double check?

@acezen
Copy link
Collaborator

acezen commented Sep 14, 2021

Can we implement the two algorithms as one app ?
we can send a parameter to check what kind of matrix computation we need

Copy link
Collaborator

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a p2p test case for attribute assortativity and numeric assortativity like degree_assortativity_coefficient

Copy link
Collaborator

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@acezen acezen merged commit c972b60 into alibaba:main Sep 22, 2021
NetworkX compatibility automation moved this from In progress to Done Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants