Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover log4rs.yml of graphscope-store and fix the log output location #814

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Sep 15, 2021

What do these changes do?

  • the log4rs.yml has been unified in commit. Since the store-ctl has been separate from giectl, the log4rs.yml need to be recovered too.
  • fix the log output location of logback.yml and log4rs.yml

Related issue number

Fixes #813

@yecol
Copy link
Collaborator

yecol commented Sep 15, 2021

Since in this PR, you are assigning log path, it raises two questions:

  1. why do you assign two different log paths in one PR? i.e., /tmp/logs and /tmp/graphscope-store
  2. in common practices, unix-like systems usually output log files to /var/logs or /var/log rather than /tmp, do we have any specific reasons to place logs in /tmp?

@yecol
Copy link
Collaborator

yecol commented Sep 15, 2021

It is OK to merge this PR. I open another issue regards to the comments above.
#815

@acezen
Copy link
Collaborator Author

acezen commented Sep 15, 2021

Since in this PR, you are assigning log path, it raises two questions:

  1. why do you assign two different log paths in one PR? i.e., /tmp/logs and /tmp/graphscope-store
  2. in common practices, unix-like systems usually output log files to /var/logs or /var/log rather than /tmp, do we have any specific reasons to place logs in /tmp?
  1. /tmp/logs is a default log4rs.yml setting of gie, /tmp/graphscope-store is for graphscope-store.
  2. user graphscope has no permission to write in /var

@yecol
Copy link
Collaborator

yecol commented Sep 15, 2021

  1. the "default" is not well designed then.
  2. google it, use keywords like log to var permission denied, it is well answered.

@acezen acezen merged commit d21de37 into alibaba:main Sep 15, 2021
@acezen acezen deleted the acezen/fix-store-log branch September 15, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recover the log4rs setting of graphscope-store
3 participants