Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg groot #887

Merged
merged 30 commits into from
Oct 13, 2021
Merged

Reorg groot #887

merged 30 commits into from
Oct 13, 2021

Conversation

tianliplus
Copy link
Collaborator

@tianliplus tianliplus commented Oct 9, 2021

What do these changes do?

reorg groot to split store and computation

Related issue number

Fixes #889

@tianliplus tianliplus requested review from shirly121, yecol and a user October 9, 2021 09:33
<dependencies>
<dependency>
<groupId>com.alibaba.maxgraph</groupId>
<artifactId>servers</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a more specific and self-described name would be better?
i.e., groot-server.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codefactor-io
Copy link

codefactor-io bot commented Oct 12, 2021

CodeFactor found multiple issues:

Unnecessary "else" after "return"

All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '252'.

Definition of 'equals()' without corresponding definition of 'hashCode()'.

switch without "default" clause.

Complex Method

Resolve unexpected comment.

@alibaba alibaba deleted a comment from codefactor-io bot Oct 12, 2021
@tianliplus tianliplus merged commit 308f35e into main Oct 13, 2021
@siyuan0322 siyuan0322 deleted the reorg_groot branch October 14, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reorg groot, sperate servers from groot core
3 participants