fix cascading engine submit; Run specified event engine in CI test #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beef9999
force-pushed
the
beef9999/fix-cascading-engine-submit
branch
from
e79d621
to
45be325
Compare
beef9999
commented
Nov 23, 2023
| } | ||
| } | ||
|
|
||
| m_eventfd = eventfd(0, EFD_CLOEXEC | EFD_NONBLOCK); | ||
| m_eventfd = eventfd(0, EFD_CLOEXEC); | ||
| if (m_eventfd < 0) { |
There was a problem hiding this comment.
这里还是应该用blocking fd，因为io_uring处理fd都是blocking的。non-blocking读的时候可能会EAGIN，代码没处理，会多跑一遍循环。
Blocking fd should still be used here, because io_uring handles fd with blocking. EAGIN may occur during non-blocking reading, and the code will not be processed and the loop will be run one more time.
beef9999
changed the title
beef9999
force-pushed
the
beef9999/fix-cascading-engine-submit
branch
from
45be325
to
4942458
Compare
This was referenced Nov 23, 2023
beef9999
force-pushed
the
beef9999/fix-cascading-engine-submit
branch
3 times, most recently
from
2a50376
to
c522b7d
Compare
beef9999
force-pushed
the
beef9999/fix-cascading-engine-submit
branch
from
c522b7d
to
fd43f42
Compare
lihuiba
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.